Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-1587][Sort] Fix compile error #1588

Merged
merged 1 commit into from Sep 26, 2021
Merged

[INLONG-1587][Sort] Fix compile error #1588

merged 1 commit into from Sep 26, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 24, 2021

Fixes #1587

Motivation

When compile under JDK11, it will build failed. And the latest Intellij IDEA internal is jdk11.

[ERROR] Failed to execute goal on project sort-core: Could not resolve dependencies for project org.apache.inlong:sort-core:jar:0.11.0-incubating-SNAPSHOT: Could not find artifact jdk.tools:jdk.tools:jar:1.7 at specified path /work/JAVA_WORK/jdk/jdk/../lib/tools.jar -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 

Modifications

Exclude hbase dependency.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@dockerzhang dockerzhang changed the title [INLONG-1587] Fix compile error [INLONG-1587][Sort] Fix compile error Sep 26, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1588 (6a8b809) into master (385b2a9) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1588      +/-   ##
============================================
- Coverage     12.19%   12.19%   -0.01%     
+ Complexity     1049     1048       -1     
============================================
  Files           392      392              
  Lines         32755    32755              
  Branches       5159     5159              
============================================
- Hits           3995     3994       -1     
  Misses        27995    27995              
- Partials        765      766       +1     
Impacted Files Coverage Δ
.../producer/qltystats/DefaultBrokerRcvQltyStats.java 45.31% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 385b2a9...6a8b809. Read the comment docs.

@ApocalypseWan
Copy link
Contributor

LGTM

@dockerzhang dockerzhang assigned ghost Sep 26, 2021
@dockerzhang
Copy link
Contributor

dockerzhang commented Sep 26, 2021

@leo65535 great job.
it's better to use another branch for the next PR, leo65535:master is not a good choice.

@dockerzhang dockerzhang merged commit e88fee9 into apache:master Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix compile error
4 participants