Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-1602] Optimize EntityStatus enum #1603

Merged
merged 1 commit into from
Oct 11, 2021
Merged

[INLONG-1602] Optimize EntityStatus enum #1603

merged 1 commit into from
Oct 11, 2021

Conversation

ruanwenjun
Copy link
Member

close #1602

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_patch1602 branch 2 times, most recently from 438ef2a to b0164ab Compare October 10, 2021 06:24
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2021 •
edited
Loading

Codecov Report

Merging #1603 (287d165) into master (73d1496) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1603   +/-   ##
=========================================
  Coverage     12.19%   12.19%           
- Complexity     1048     1049    +1     
=========================================
  Files           392      392           
  Lines         32755    32755           
  Branches       5159     5159           
=========================================
+ Hits           3994     3995    +1     
+ Misses        27998    27995    -3     
- Partials        763      765    +2
Impacted Files Coverage Δ
.../producer/qltystats/DefaultBrokerRcvQltyStats.java 45.70% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d1496...287d165. Read the comment docs.

gosonzhang
gosonzhang approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

dockerzhang
dockerzhang approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@dockerzhang dockerzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang merged commit c93a18a into apache:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baomingyu baomingyu baomingyu approved these changes

@gosonzhang gosonzhang gosonzhang approved these changes

@dockerzhang dockerzhang dockerzhang approved these changes

Assignees
No one assigned
Labels
component/manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve] Optimize EntityStatus enum
5 participants
@ruanwenjun @codecov-commenter @baomingyu @gosonzhang @dockerzhang