Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-1670][Manager] Add H2 in UT #1671

Merged
merged 1 commit into from
Oct 19, 2021
Merged

[INLONG-1670][Manager] Add H2 in UT #1671

merged 1 commit into from
Oct 19, 2021

Conversation

ruanwenjun
Copy link
Member

close #1670

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021 •
edited
Loading

Codecov Report

Merging #1671 (96e0e98) into master (736a28e) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1671      +/-   ##
============================================
- Coverage     12.21%   12.20%   -0.02%     
- Complexity     1048     1050       +2     
============================================
  Files           392      392              
  Lines         32755    32755              
  Branches       5159     5159              
============================================
- Hits           4001     3997       -4     
- Misses        27989    27993       +4     
  Partials        765      765
Impacted Files Coverage Δ
.../java/org/apache/flume/sink/tubemq/TubemqSink.java 51.42% <0.00%> (-4.00%) ⬇️
.../tubemq/corebase/policies/FlowCtrlRuleHandler.java 34.51% <0.00%> (+0.44%) ⬆️
.../inlong/tubemq/corebase/policies/FlowCtrlItem.java 40.00% <0.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736a28e...96e0e98. Read the comment docs.

@dockerzhang
Copy link
Contributor

@healchow PTAL, thanks.

healchow
healchow reviewed Oct 19, 2021
View reviewed changes
...ao/src/test/java/org/apache/inlong/manager/dao/config/InLongManagerDatasourceConfigTest.java Outdated
@Test
public void dataSource() {
DataSource dataSource = inLongManagerDatasourceConfig.dataSource();
System.out.println(dataSource);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the println code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

healchow
healchow approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang merged commit b3566e1 into apache:master Oct 19, 2021
@ruanwenjun ruanwenjun mentioned this pull request Oct 20, 2021
Merged
@dockerzhang dockerzhang added this to the 0.11.0 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dockerzhang dockerzhang dockerzhang approved these changes

@healchow healchow healchow approved these changes

@aloyszhang aloyszhang aloyszhang approved these changes

Assignees

@ruanwenjun ruanwenjun

Labels
component/manager
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

[Improve][Manager] Add H2 in UT
5 participants
@ruanwenjun @codecov-commenter @dockerzhang @healchow @aloyszhang