Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-2070] update the default pulsar demo configuration for dataproxy #2071

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

dockerzhang
Copy link
Contributor

Title Name: [INLONG-XYZ][component] Title of the pull request

where XYZ should be replaced by the actual issue number.

Fixes #2070

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov-commenter
Copy link

Codecov Report

Merging #2071 (ce91a17) into master (12b4004) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2071   +/-   ##
=========================================
  Coverage     12.28%   12.29%           
- Complexity     1158     1160    +2     
=========================================
  Files           413      413           
  Lines         35215    35215           
  Branches       5542     5542           
=========================================
+ Hits           4326     4329    +3     
+ Misses        30119    30117    -2     
+ Partials        770      769    -1     
Impacted Files Coverage Δ
.../tubemq/corebase/policies/FlowCtrlRuleHandler.java 34.51% <0.00%> (+0.44%) ⬆️
.../inlong/tubemq/corebase/policies/FlowCtrlItem.java 40.00% <0.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b4004...ce91a17. Read the comment docs.

Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@healchow healchow merged commit 58c11f4 into apache:master Dec 29, 2021
@dockerzhang dockerzhang deleted the fix-2070 branch February 11, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve] update the default pulsar demo configuration for dataproxy
4 participants