Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-2263] SortStandalone get metric value with error JMX ObjectName #2265

Merged
merged 9 commits into from
Jan 23, 2022
Merged

[INLONG-2263] SortStandalone get metric value with error JMX ObjectName #2265

merged 9 commits into from
Jan 23, 2022

Conversation

luchunliang
Copy link
Contributor

Title Name: [INLONG-2263][Inlong-SortStandalone] SortStandalone get metric value with error JMX ObjectName

Fixes #2263

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2022

Codecov Report

Merging #2265 (0f165bc) into master (57cf8a7) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2265      +/-   ##
============================================
+ Coverage     12.52%   12.54%   +0.01%     
- Complexity     1215     1217       +2     
============================================
  Files           420      420              
  Lines         36208    36235      +27     
  Branches       5674     5674              
============================================
+ Hits           4536     4545       +9     
- Misses        30865    30881      +16     
- Partials        807      809       +2     
Impacted Files Coverage Δ
...emq/server/common/paramcheck/PBParameterUtils.java 24.20% <0.00%> (-0.92%) ⬇️
...long/tubemq/server/broker/BrokerServiceServer.java 0.00% <0.00%> (ø)
...g/tubemq/server/broker/web/BrokerAdminServlet.java 0.00% <0.00%> (ø)
...bemq/server/master/metamanage/MetaDataManager.java 0.00% <0.00%> (ø)
...q/client/consumer/SimpleClientBalanceConsumer.java 0.00% <0.00%> (ø)
...rver/master/web/handler/WebTopicDeployHandler.java 0.00% <0.00%> (ø)
...ong/tubemq/server/common/fielddef/WebFieldDef.java 96.35% <0.00%> (+0.05%) ⬆️
...ng/tubemq/corebase/utils/DateTimeConvertUtils.java 92.50% <0.00%> (+0.39%) ⬆️
.../tubemq/server/common/utils/WebParameterUtils.java 18.65% <0.00%> (+0.70%) ⬆️
.../producer/qltystats/DefaultBrokerRcvQltyStats.java 45.31% <0.00%> (+1.17%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57cf8a7...0f165bc. Read the comment docs.

@healchow healchow merged commit 18bb2e1 into apache:master Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] SortStandalone get metric value with error JMX ObjectName
4 participants