[INLONG-2161][Feature][Manager] add the sort_cluster_config table for getClusterConfig interface #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2287 +/- ##
=========================================
Coverage 12.54% 12.54%
Complexity 1217 1217
=========================================
Files 420 420
Lines 36235 36229 -6
Branches 5674 5670 -4
=========================================
Hits 4545 4545
+ Misses 30881 30875 -6
Partials 809 809
Continue to review full report at Codecov.
|
dockerzhang
changed the title
dockerzhang
requested review from
gosonzhang,
dockerzhang and
aloyszhang
and removed request for
gosonzhang
dockerzhang
approved these changes
Jan 23, 2022
dockerzhang
requested review from
healchow
and removed request for
aloyszhang
luchunliang
reviewed
Jan 23, 2022
| private String clusterName; | ||
| private String taskName; | ||
| private String sinkType; | ||
| private static final long serialVersionUID = 1L; |
There was a problem hiding this comment.
serialVersionUID is invalid.
luchunliang
reviewed
Jan 23, 2022
| enableUpdateByPrimaryKey="true" | ||
| enableDeleteByPrimaryKey="true" enableInsert="true" | ||
| enableCountByExample="false" enableDeleteByExample="false" | ||
| enableSelectByExample="false" enableUpdateByExample="false"/>--> |
There was a problem hiding this comment.
Please remove unuse code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title Name: [INLONG-2161][component] Define the sort_cluster_config table
Fixes #2161
Motivation
Define sort_cluster_config table.
Use cluster name to select the corresponding tasks and the sink type of each task.
Modifications
Add mappers of sort_cluster_config
Add invalid cluster name check.
Add UT of blank cluster name
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation