-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INLONG-2161][Manager] Add sort_id_params table for getClusterConfig interface #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2299 +/- ##
=========================================
Coverage 12.53% 12.54%
- Complexity 1217 1218 +1
=========================================
Files 420 420
Lines 36229 36240 +11
Branches 5670 5670
=========================================
+ Hits 4543 4546 +3
- Misses 30882 30886 +4
- Partials 804 808 +4
Continue to review full report at Codecov.
|
wardlican
reviewed
Jan 24, 2022
...nager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/SortIdParamsEntity.java
Outdated
Show resolved
Hide resolved
wardlican
reviewed
Jan 24, 2022
inlong-manager/manager-dao/src/main/resources/mappers/SortIdParamsEntityMapper.xml
Outdated
Show resolved
Hide resolved
wardlican
approved these changes
Jan 24, 2022
luchunliang
reviewed
Jan 24, 2022
...mmon/src/main/java/org/apache/inlong/manager/common/pojo/sort/SortClusterConfigResponse.java
Outdated
Show resolved
Hide resolved
...nager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/SortIdParamsEntity.java
Outdated
Show resolved
Hide resolved
luchunliang
approved these changes
Jan 24, 2022
healchow
approved these changes
Jan 25, 2022
healchow
reviewed
Jan 25, 2022
...nager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/SortIdParamsEntity.java
Outdated
Show resolved
Hide resolved
dockerzhang
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title Name: [INLONG-2161][Feature][Manager] Add sort_id_params table for getClusterConfig interface
Fixes #2161
Motivation
Add common id params table for sort cluster config interface
Modifications
Add entity, mapper, service of common id params.
Add UT.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation