Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-2161][Manager] Add sort_id_params table for getClusterConfig interface #2299

Merged
merged 5 commits into from
Jan 25, 2022

Conversation

vernedeng
Copy link
Contributor

Title Name: [INLONG-2161][Feature][Manager] Add sort_id_params table for getClusterConfig interface

Fixes #2161

Motivation

Add common id params table for sort cluster config interface

Modifications

Add entity, mapper, service of common id params.
Add UT.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2022

Codecov Report

Merging #2299 (7af3bfb) into master (ab9e725) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2299   +/-   ##
=========================================
  Coverage     12.53%   12.54%           
- Complexity     1217     1218    +1     
=========================================
  Files           420      420           
  Lines         36229    36240   +11     
  Branches       5670     5670           
=========================================
+ Hits           4543     4546    +3     
- Misses        30882    30886    +4     
- Partials        804      808    +4     
Impacted Files Coverage Δ
.../inlong/tubemq/corebase/policies/FlowCtrlItem.java 38.88% <0.00%> (-1.12%) ⬇️
.../tubemq/corebase/policies/FlowCtrlRuleHandler.java 34.07% <0.00%> (-0.45%) ⬇️
.../inlong/tubemq/server/common/TServerConstants.java 0.00% <0.00%> (ø)
...g/tubemq/server/broker/web/BrokerAdminServlet.java 0.00% <0.00%> (ø)
...emq/server/broker/offset/DefaultOffsetManager.java 0.00% <0.00%> (ø)
.../producer/qltystats/DefaultBrokerRcvQltyStats.java 45.70% <0.00%> (+1.56%) ⬆️
.../client/producer/qltystats/BrokerStatsItemSet.java 72.09% <0.00%> (+4.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab9e725...7af3bfb. Read the comment docs.

@healchow healchow changed the title [INLONG-2161][Feature][Manager] Add sort_id_params table for getClusterConfig interface [INLONG-2161][Manager] Add sort_id_params table for getClusterConfig interface Jan 25, 2022
@dockerzhang dockerzhang merged commit 7d78a04 into apache:master Jan 25, 2022
@vernedeng vernedeng deleted the INLONG-2161 branch January 28, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][InLong-Manager] Manager support getClusterConfig
6 participants