Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-2465][Manager] GetClusterConfig interface support select sinkParams #2439

Merged
merged 4 commits into from
Feb 14, 2022

Conversation

vernedeng
Copy link
Contributor

@vernedeng vernedeng commented Feb 10, 2022

Title Name: [INLONG-2465][Manager] GetClusterConfig interface support select sinkParams

Fixes #2465

Motivation

Last part of getClusterconfig interface.

Modifications

Add sink params table which maintain the params of sort sink.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@vernedeng vernedeng changed the title [INLONG-2161][Manager] GetClusterConfig interface support sink [INLONG-2161][Manager] GetClusterConfig interface support select sinkParams Feb 10, 2022
@dockerzhang dockerzhang added this to the 1.1.0 milestone Feb 11, 2022
@dockerzhang
Copy link
Contributor

@ImVan please create an issue for this PR, #2161 has been fixed.

@vernedeng vernedeng changed the title [INLONG-2161][Manager] GetClusterConfig interface support select sinkParams [INLONG-2465][Manager] GetClusterConfig interface support select sinkParams Feb 11, 2022
@vernedeng
Copy link
Contributor Author

vernedeng commented Feb 11, 2022

@ImVan please create an issue for this PR, #2161 has been fixed.

thx, i have created a new issue #2465

@healchow healchow merged commit 2854756 into apache:master Feb 14, 2022
@vernedeng vernedeng deleted the INLONG-2161 branch May 26, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Manager] GetClusterConfig interface support select sinkParams
6 participants