[INLONG-2596][TubeMQ] fix param error and add override annotation #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yimaixinchen please create an issue firstly, and this PR should relate to the issue. you can refer to other PR, like #2592. thanks. |
|
I create the issue. |
|
If the issue is not standard,please be patient and guide me how to do. |
dockerzhang
changed the title
dockerzhang
changed the title
|
@EMsnap @gosonzhang PTAL |
gosonzhang
approved these changes
Feb 19, 2022
|
@yimaixinchen thanks for your contribution for #2596, there are lots of tasks you could do if you are interested in the issue list, look for your forward PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix param error and add override annotation
I think it is easy to be merged
fix #2596