Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-2813][Docker] Update the docker config for getting TubeMq config dynamically #2814

Merged
merged 2 commits into from
Mar 2, 2022
Merged

[INLONG-2813][Docker] Update the docker config for getting TubeMq config dynamically #2814

merged 2 commits into from
Mar 2, 2022

Conversation

dockerzhang
Copy link
Contributor

@dockerzhang dockerzhang commented Mar 2, 2022 •
edited by healchow
Loading

Title Name: [INLONG-2813][Docker] Update the docker config for getting TubeMq config dynamically

Fixes #2813

Motivation

Due to #2568 having supported dynamically getting TubeMq config from Manager, here we should change the docker config at the same time.

pocozh
pocozh approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@pocozh pocozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@healchow healchow changed the title [INLONG-2813][docker] update the docker config for getting TubeMq config dynamically [INLONG-2813][Docker] Update the docker config for getting TubeMq config dynamically Mar 2, 2022
EMsnap
EMsnap approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dockerzhang dockerzhang merged commit 1c40ca6 into apache:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EMsnap EMsnap EMsnap approved these changes

@healchow healchow healchow approved these changes

@pocozh pocozh pocozh approved these changes

@gosonzhang gosonzhang Awaiting requested review from gosonzhang

Assignees
No one assigned
Labels
component/dataproxy component/manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve] update the docker config for getting TubeMq config dynamically
4 participants
@dockerzhang @EMsnap @healchow @pocozh