Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-2651][Sort] Add CLS sink, and UT #2919

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

vernedeng
Copy link
Contributor

@vernedeng vernedeng commented Mar 4, 2022

Title Name: [INLONG-2651][Sort] Add CLS sink, and UT

Fixes #2651

Modifications

Add ClsChannelWorker that acquire events from channel and send it by calling cls sdk. The process of sending implements transaction.

ClsSink is response for the maintainance of ClsChannelWorker .

Verifying this chang。

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@aloyszhang aloyszhang added this to the 1.1.0 milestone Mar 4, 2022
Copy link
Contributor

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dockerzhang dockerzhang merged commit dc7be87 into apache:master Mar 7, 2022
@vernedeng vernedeng deleted the INLONG-2651 branch May 26, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Sort] Add CLS sink
5 participants