Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INGLONG-3202][SDK] Unify SortSourceConfig of manager and sdk #3211

Closed
wants to merge 4 commits into from

Conversation

vernedeng
Copy link
Contributor

@vernedeng vernedeng commented Mar 18, 2022

Title Name: [INGLONG-3202][SDK] Unify SortSourceConfig of manager and sdk

Fixes #3202

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@vernedeng vernedeng closed this Mar 18, 2022
@vernedeng vernedeng deleted the INLONG-3202 branch March 18, 2022 04:11
@healchow
Copy link
Member

Fixed by #3215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][SDK] Unify SortSourceConfig of Sort-Sdk and Manager
4 participants