Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-3369][Manager] Add streamsource in group/list Api #3374

Merged
merged 4 commits into from
Mar 26, 2022

Conversation

kipshi
Copy link
Contributor

@kipshi kipshi commented Mar 26, 2022

Title Name:[INLONG-3369] Add streamsource in group/list Api

where XYZ should be replaced by the actual issue number.

Fixes #3369

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang changed the title [INLONG-3369] Add streamsource in group/list Api [INLONG-3369][Manager] Add streamsource in group/list Api Mar 26, 2022
@gosonzhang gosonzhang merged commit 305d458 into apache:master Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Manager] Add StreamSource in list API
4 participants