Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-4092][Manager] Add primary key in Kafka source #4094

Merged
merged 5 commits into from
May 6, 2022

Conversation

kipshi
Copy link
Contributor

@kipshi kipshi commented May 6, 2022

Title Name: [INLONG-4092][Manager]Add primary key in Kafka source

where XYZ should be replaced by the actual issue number.

Fixes #4092

Motivation

Modifications

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@healchow healchow changed the title [INLONG-4092][Manager]Add primary key in Kafka source [INLONG-4092][Manager] Add primary key in Kafka source May 6, 2022
@healchow healchow merged commit e507c0e into apache:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Manager] Add primary key in Kafka source
4 participants