Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-4208][Manager] Merge UpdateGroupProcessForm into GroupResourceProcessForm #4209

Merged
merged 1 commit into from
May 16, 2022
Merged

[INLONG-4208][Manager] Merge UpdateGroupProcessForm into GroupResourceProcessForm #4209

merged 1 commit into from
May 16, 2022

Conversation

kipshi
Copy link
Contributor

@kipshi kipshi commented May 16, 2022

Title Name: [INLONG-4208][Manager] Merge UpdateGroupProcessForm into GroupResourceProcessForm

where XYZ should be replaced by the actual issue number.

Fixes #4208

Motivation

Modifications

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

healchow
healchow approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@healchow healchow self-requested a review May 16, 2022 04:42
@dockerzhang dockerzhang merged commit c1e3bc3 into apache:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dockerzhang dockerzhang dockerzhang approved these changes

@healchow healchow Awaiting requested review from healchow

Assignees

@kipshi kipshi

Labels
component/manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve][Manager] Merge UpdateGroupProcessForm into GroupResourceProcessForm
3 participants
@kipshi @dockerzhang @healchow