Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-5290][Manager] Optimize the objects returned by manager web paging queries #5558

Merged
merged 7 commits into from
Aug 25, 2022
Merged

[INLONG-5290][Manager] Optimize the objects returned by manager web paging queries #5558

merged 7 commits into from
Aug 25, 2022

Conversation

leosanqing
Copy link
Contributor

Prepare a Pull Request

Motivation

  • The pageInfo object returned by the web contains too many unnecessary and unused fields
  • The client should not contain the PageHelper dependency

Modifications

  • Modules: Client,Web(Controller)

Verifying this change

(Please pick either of the following options)

  • This change is already covered by existing tests, such as:
    • PageResultTest

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

healchow
healchow approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang added this to the 1.4.0 milestone Aug 25, 2022
@healchow healchow merged commit 1f0ec44 into apache:master Aug 25, 2022
EMsnap pushed a commit that referenced this pull request Aug 25, 2022
@leosanqing @EMsnap
[INLONG-5290][Manager] Optimize the objects returned by paging queries (
9fe9c54 
#5558)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woofyzhao woofyzhao woofyzhao approved these changes

@dockerzhang dockerzhang dockerzhang approved these changes

@healchow healchow healchow approved these changes

Assignees
No one assigned
Labels
component/manager
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

[Improve][Manager] Optimize the objects returned by paging queries
4 participants
@leosanqing @woofyzhao @dockerzhang @healchow