Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-5694][Manager] Fix the problem that gets the inlong group error #5695

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

fuweng11
Copy link
Contributor

Prepare a Pull Request

Motivation

Make sure the group information of initsort failure can be viewed normally

Modifications

This ensures that no null pointer exception will be reported when getting the sort configuration information.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

Documentation

  • Does this pull request introduce a new feature? (no)

@fuweng11 fuweng11 changed the title [INLONG-5694][Manager] Click to view the group info of initsort execution failure and report an error [INLONG-5694][Manager] Fix the problem that when you click to view the group information of initsort execution failure and report an error Aug 25, 2022
@fuweng11 fuweng11 changed the title [INLONG-5694][Manager] Fix the problem that when you click to view the group information of initsort execution failure and report an error [INLONG-5694][Manager] Fix the problem that when click to view the group information of initsort execution failure and report an error Aug 25, 2022
@healchow healchow changed the title [INLONG-5694][Manager] Fix the problem that when click to view the group information of initsort execution failure and report an error [INLONG-5694][Manager] Fix the problem that gets the inlong group error Aug 25, 2022
@healchow healchow added the type/bug Something is wrong label Aug 25, 2022
@woofyzhao
Copy link
Contributor

suggest searching for similar code snippets in case there are more like this

@leosanqing
Copy link
Contributor

I find this article,They gave a solution, I tried it and it works: https://stackoverflow.com/questions/24630963/nullpointerexception-in-collectors-tomap-with-null-entry-values

image

@fuweng11
Copy link
Contributor Author

I find this article,They gave a solution, I tried it and it works: https://stackoverflow.com/questions/24630963/nullpointerexception-in-collectors-tomap-with-null-entry-values

image
I don't think it's necessary to force the stream function to make the code hard to read.

@woofyzhao
Copy link
Contributor

I find this article,They gave a solution, I tried it and it works: https://stackoverflow.com/questions/24630963/nullpointerexception-in-collectors-tomap-with-null-entry-values
image
I don't think it's necessary to force the stream function to make the code hard to read.

Agreed.

@leosanqing
Copy link
Contributor

I find this article,They gave a solution, I tried it and it works: https://stackoverflow.com/questions/24630963/nullpointerexception-in-collectors-tomap-with-null-entry-values

image I don't think it's necessary to force the stream function to make the code hard to read.

Yes, that article just tells why the NPE occurs, and then provides a workaround.
It's not mandatory, nor necessary, that kind of performance is bad

@dockerzhang dockerzhang merged commit a133995 into apache:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Manager] Get the inlong group failed when the Init-Sort task execution failed
5 participants