Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-5781][Manager] Support creating consumer groups for all sinks #5782

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

healchow
Copy link
Member

@healchow healchow commented Sep 5, 2022

Prepare a Pull Request

Motivation

Support creating consumer groups for all sinks.

Modifications

For Pulsar, an InlongStream maps a Pulsar Topic.

And we support the creation of multiple StreamSinks under the same InlongStreamId, which means that Sort needs to consume the data in the Topic once for each StreamSink, so a consumer group must be created for each StreamSink.

Verifying this change

  • This change is a trivial rework/code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (JavaDocs)

Copy link
Contributor

@yunqingmoswu yunqingmoswu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to maintain forward compatibility at the protocol level.

@healchow healchow merged commit 9844199 into apache:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Manager] Support creating consumer groups for all sinks
5 participants