-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INLONG-5956][Manager] Support MySQL node configuration #5957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d499887
to
d8cdcfe
Compare
healchow
reviewed
Sep 20, 2022
...r/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/mysql/MySQLDataNodeDTO.java
Outdated
Show resolved
Hide resolved
healchow
reviewed
Sep 20, 2022
.../manager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/mysql/MySQLDataNodeInfo.java
Outdated
Show resolved
Hide resolved
healchow
reviewed
Sep 20, 2022
.../manager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/mysql/MySQLDataNodeInfo.java
Outdated
Show resolved
Hide resolved
healchow
reviewed
Sep 20, 2022
...ager-service/src/main/java/org/apache/inlong/manager/service/node/MySQLDataNodeOperator.java
Outdated
Show resolved
Hide resolved
woofyzhao
approved these changes
Sep 20, 2022
healchow
requested changes
Sep 21, 2022
.../manager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/mysql/MySQLDataNodeInfo.java
Outdated
Show resolved
Hide resolved
...ager-service/src/main/java/org/apache/inlong/manager/service/node/MySQLDataNodeOperator.java
Outdated
Show resolved
Hide resolved
healchow
reviewed
Sep 21, 2022
...r/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/mysql/MySQLDataNodeDTO.java
Outdated
Show resolved
Hide resolved
3af46a6
to
b3c0e54
Compare
3a606c7
to
f9e0f37
Compare
healchow
approved these changes
Sep 21, 2022
dockerzhang
approved these changes
Sep 21, 2022
dockerzhang
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Motivation
Support MySQL node and dbsync cluster configuration
Modifications
Added MySQL and dbsync related request, info, and DTO classes
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
Documentation