Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-6014][Manager] Int type cannot be compared with null using == #6015

Merged
merged 1 commit into from
Sep 24, 2022

Conversation

ciscozhou
Copy link
Contributor

Prepare a Pull Request

Motivation

When an int is compared to an Integer, the Integer may be null.

Modifications

Use equals to compare two numbers for the same

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@healchow healchow changed the title [INLONG-6014][Manager] Int type cannot be compared with null using "==" [INLONG-6014][Manager] Int type cannot be compared with null using == Sep 24, 2022
@dockerzhang dockerzhang merged commit dd1b8fd into apache:master Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Manager] Int type cannot be compared with null using ==
3 participants