[INLONG-6352][Manager] Add a global config for whether to use ZooKeeper to manage the Sort task #6354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ough zk using the global configuration
healchow
reviewed
Nov 1, 2022
...er-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java
Outdated
Show resolved
Hide resolved
healchow
reviewed
Nov 1, 2022
inlong-manager/manager-web/src/main/resources/application-dev.properties
Outdated
Show resolved
Hide resolved
healchow
approved these changes
Nov 1, 2022
healchow
changed the title
gosonzhang
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
(Change the title refer to the following example)
Motivation
Set whether to push the sort configuration through zk using the global configuration
Modifications
The global configuration
sort.enable.zookeeperhas been added to the configuration file.This configuration is used to determine whether to push the sort configuration to zk.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
Documentation