[INLONG-6600][Sort] Fix dead lock when one stream is removed from or migrated to one sink #6601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d from or migrated to one sink
doleyzi
approved these changes
Nov 22, 2022
healchow
approved these changes
Nov 24, 2022
dockerzhang
changed the title
dockerzhang
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When one stream is removed from or migrated to one sink, the unsent ES request will be retried and failed forever.
Modifications
Check if the EsIdConfig is still exist before each send. If no, discard this request.
Verifying this change
(Please pick either of the following options)
Documentation