Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-6784][Sort] Support load node of Apache Hudi #6789

Merged
merged 1 commit into from
Dec 9, 2022
Merged

[INLONG-6784][Sort] Support load node of Apache Hudi #6789

merged 1 commit into from
Dec 9, 2022

Conversation

featzhang
Copy link
Member

Prepare a Pull Request

[INLONG-6784][Sort] Support apache hudi LoadNode

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve?

Modifications

Describe the modifications you've done.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@healchow healchow changed the title [INLONG-6784][Sort] Support apache hudi LoadNode [INLONG-6784][Sort] Support load node of Apache Hudi Dec 8, 2022
EMsnap
EMsnap reviewed Dec 8, 2022
View reviewed changes
Copy link
Contributor

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Test in sort-core/src/test/parser

@dockerzhang dockerzhang mentioned this pull request Dec 9, 2022
Closed
1 task
@gong gong merged commit 4c6a61b into apache:master Dec 9, 2022
@featzhang featzhang deleted the hudi-loadnode branch December 14, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunqingmoswu yunqingmoswu yunqingmoswu left review comments

@gong gong gong approved these changes

@dockerzhang dockerzhang dockerzhang approved these changes

@EMsnap EMsnap EMsnap approved these changes

@healchow healchow healchow approved these changes

Assignees
No one assigned
Labels
component/sort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Sort] Support load node of Apache Hudi
6 participants
@featzhang @gong @dockerzhang @EMsnap @healchow @yunqingmoswu