Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-7075][Sort] Add table level metric and dirty data backup for PostgreSQL #7088

Merged
merged 4 commits into from
Dec 30, 2022

Conversation

kuansix
Copy link
Contributor

@kuansix kuansix commented Dec 29, 2022

Prepare a Pull Request

(Change the title refer to the following example)

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve?

Modifications

Describe the modifications you've done.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@gong
Copy link
Contributor

gong commented Dec 29, 2022

lost dirty metric data init

@kuansix
Copy link
Contributor Author

kuansix commented Dec 29, 2022

lost dirty metric data init

done. and add dirty data backup.

@kuansix kuansix changed the title [INLONG-7075][Sort] Add table level metric for PostgreSQL [INLONG-7075][Sort] Add table level metric and backup for PostgreSQL Dec 29, 2022
@kuansix kuansix changed the title [INLONG-7075][Sort] Add table level metric and backup for PostgreSQL [INLONG-7075][Sort] Add table level metric and dirty data backup for PostgreSQL Dec 29, 2022
@gong
Copy link
Contributor

gong commented Dec 30, 2022

dirtySinkHelper should call open method yo init config. table is dynamic, so you can't invoke invoke(T dirtyData, DirtyType dirtyType, Throwable e), maybe you need call like setLabels("", dirtyOptions.getLabels()))

@kuansix
Copy link
Contributor Author

kuansix commented Dec 30, 2022

setLabels

Will be unified processed by @Yizhou-Yang

@gong gong merged commit f8d3989 into apache:master Dec 30, 2022
liaorui pushed a commit to liaorui/inlong that referenced this pull request Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Sort] Add table level metric and dirty data backup for PostgreSQL
4 participants