[INLONG-7411][Sort] Fix the invalid of kafka source meitric due to inlongMetric being null #7409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lordcheng10 please create a related issue first. |
healchow
approved these changes
Feb 23, 2023
|
After creating an issue, please change the [INLONG-your_issue_number] in this PR title. |
gong
reviewed
Feb 23, 2023
...s/kafka/src/main/java/org/apache/inlong/sort/kafka/table/UpsertKafkaDynamicTableFactory.java
Outdated
Show resolved
Hide resolved
lordcheng10
changed the title
Fixed,PTAL,thanks! @dockerzhang |
gong
approved these changes
Feb 23, 2023
dockerzhang
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix the invalid of kafka source meitric due to inlongMetric being null
Modifications
In the createDynamicTableSource method of the UpsertKafkaDynamicTableFactory class, when building a KafkaDynamicSource object, you need to pass in the INLONG_METRIC configuration