[INLONG-7855][Sort] Fix Sort hang up reader in snapshot phase when reducing parallelism #7856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ducing parallelism
yunqingmoswu
approved these changes
Apr 14, 2023
healchow
approved these changes
Apr 14, 2023
healchow
reviewed
Apr 14, 2023
...c/src/main/java/org/apache/inlong/sort/cdc/mysql/debezium/task/MySqlBinlogSplitReadTask.java
Outdated
Show resolved
Hide resolved
dockerzhang
approved these changes
Apr 14, 2023
|
Please run |
yunqingmoswu
approved these changes
Apr 17, 2023
e-mhui
approved these changes
Apr 17, 2023
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Motivation
Fix Sort hang up reader in snapshot phase when reducing parallelism
1、When a subtask receives two chunk splits to read;
2、The first chunk reads perfectly, and then it will start a BinlogClient to read the binlogs from lw to hw in chunk1.
3、When the second chunk arrives the BinlogClient will be reused
4、So when reading chunk2 and start to read from lw to hw in chunk2, the binlog reader will be reused and the event listener in chunk1 will be reused also. So that the BINLOG_END event in chunk2 will never be received
Modifications
remove the eventListener in the formal chunk
Documentation