[IOTDB-6305] Add show current_timestamp statement #12106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackieTien97
approved these changes
Mar 1, 2024
HTHou
reviewed
Mar 1, 2024
| .collect(Collectors.toList()); | ||
| TsBlockBuilder tsBlockBuilder = new TsBlockBuilder(outputDataTypes); | ||
| tsBlockBuilder.getTimeColumnBuilder().writeLong(0L); | ||
| tsBlockBuilder.getColumnBuilder(0).writeLong(System.currentTimeMillis()); |
There was a problem hiding this comment.
Is there any issue when the timestamp_precision is ns or us? @JackieTien97
There was a problem hiding this comment.
It's a long value, how to resolve this long value depends on the user. We can default return ms, in stardand sql, there will be a parameter called precision in current_timestamp function to decide whether to return ms, us or ns, so I think it's ok to defaultly return ms here and this function call's time precision should have nothing to do with our timestamp_precision configuration.
yx-zhang
force-pushed
the
show_current_timestamp
branch
from
fa61eaa
to
a486fb5
Compare
HTHou
approved these changes
Mar 1, 2024
yx-zhang
force-pushed
the
show_current_timestamp
branch
from
6a50fac
to
fad6e18
Compare
HTHou
pushed a commit
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://issues.apache.org/jira/browse/IOTDB-6305