Refactor IQueryExecution to support Table Model in the future #12157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Beyyes
approved these changes
Mar 13, 2024
| @@ -63,7 +69,7 @@ | |||
| import static com.google.common.base.Preconditions.checkArgument; | |||
|
|
|||
| /** Analysis used for planning a query. TODO: This class may need to store more info for a query. */ | |||
| public class Analysis { | |||
| public class Analysis implements IAnalysis { | |||
There was a problem hiding this comment.
If renamed to TreeModelAnalysis?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr, we add
IAnalysisandIPlannerinterface inQueryExecution, delete Statement field inQueryExecutionand addTimePredicateinterface forFragmentInstanceto support Table Model in the future.