Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the bug that TimeoutChangeableTFastFramedTransport is unused so that timeout changing is disabled in thrift transferring #12186

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

Caideyipi
Copy link
Contributor

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@Caideyipi Caideyipi changed the title Bug fix Fixed the bug that TimeoutChangeableTFastFramedTransport is unused so that timeout changing is disabled in thrift transferring. Mar 18, 2024
@Caideyipi Caideyipi changed the title Fixed the bug that TimeoutChangeableTFastFramedTransport is unused so that timeout changing is disabled in thrift transferring. Fixed the bug that TimeoutChangeableTFastFramedTransport is unused so that timeout changing is disabled in thrift transferring Mar 18, 2024
@SteveYurongSu SteveYurongSu self-assigned this Mar 18, 2024
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MrQuansy MrQuansy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit cc1842c into apache:master Mar 18, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants