-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compaction rate limit #12312
Merged
OneSizeFitsQuorum
merged 13 commits into
apache:master
from
shuwenwei:compactionRateLimit
Apr 19, 2024
Merged
Compaction rate limit #12312
OneSizeFitsQuorum
merged 13 commits into
apache:master
from
shuwenwei:compactionRateLimit
Apr 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jt2594838
requested changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is generally good, but with some minor issues that would best be fixed.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java
Show resolved
Hide resolved
.../java/org/apache/iotdb/db/storageengine/dataregion/compaction/io/CompactionTsFileOutput.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/iotdb/db/storageengine/dataregion/compaction/io/CompactionTsFileOutput.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/iotdb/db/storageengine/dataregion/compaction/io/CompactionTsFileOutput.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/iotdb/db/storageengine/dataregion/compaction/io/CompactionTsFileReader.java
Outdated
Show resolved
Hide resolved
.../org/apache/iotdb/db/storageengine/dataregion/compaction/schedule/CompactionTaskManager.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
Outdated
Show resolved
Hide resolved
iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties
Outdated
Show resolved
Hide resolved
jt2594838
reviewed
Apr 16, 2024
.../org/apache/iotdb/db/storageengine/dataregion/compaction/schedule/CompactionTaskManager.java
Outdated
Show resolved
Hide resolved
jt2594838
approved these changes
Apr 16, 2024
shuwenwei
added a commit
to shuwenwei/iotdb
that referenced
this pull request
May 21, 2024
* add compaction read rate limiter * modify method name * modify default compaction read rate limit * add config item to limit compaction read speed * add config item to limit compaction read speed * fix throughput rate is not correct * fix some issues * compaction read rate has no limit in default config * use correct unit when init rate limiter * modify maxSizePerWrite * remove useless code
HTHou
pushed a commit
that referenced
this pull request
May 21, 2024
* Fix uncompress byte buffer in RepairDataFileScanUtil * Modify compaction task priority comparator (#12255) * delay estimate memory of InnerSpaceCompactionTask (#12314) * Compaction rate limit (#12312) * add compaction read rate limiter * modify method name * modify default compaction read rate limit * add config item to limit compaction read speed * add config item to limit compaction read speed * fix throughput rate is not correct * fix some issues * compaction read rate has no limit in default config * use correct unit when init rate limiter * modify maxSizePerWrite * remove useless code
HTHou
pushed a commit
that referenced
this pull request
Jun 26, 2024
* add compaction read rate limiter * modify method name * modify default compaction read rate limit * add config item to limit compaction read speed * add config item to limit compaction read speed * fix throughput rate is not correct * fix some issues * compaction read rate has no limit in default config * use correct unit when init rate limiter * modify maxSizePerWrite * remove useless code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description