Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOTDB-698] add device time index interface #1652

Closed
wants to merge 7 commits into from

Conversation

mychaow
Copy link
Member

@mychaow mychaow commented Aug 25, 2020

No description provided.

@Alima777
Copy link
Contributor

Hi, could you add some description for this pr?

@mychaow
Copy link
Member Author

mychaow commented Aug 27, 2020

Hi, could you add some description for this pr?

yes, you could see some description in jira iotdb-698

Copy link
Contributor

@SilverNarcissus SilverNarcissus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful work! We can keep away from OOM caused by metadata. Looking forward to your implementation. Only minor issues now, please have a look.

@mychaow mychaow force-pushed the master branch 2 times, most recently from c9a65a4 to f7458f1 Compare September 12, 2020 08:28
@mychaow mychaow changed the title add device time index interface [IOTDB-698] add device time index interface Sep 14, 2020
@mychaow mychaow force-pushed the master branch 2 times, most recently from 14f3141 to 14b4449 Compare September 14, 2020 04:05
Copy link
Member

@qiaojialin qiaojialin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please change this interface to FileIndexManager and make the default implementation as DeviceTimeIndexEntry

server/src/assembly/resources/conf/iotdb-engine.properties Outdated Show resolved Hide resolved
# device time indexer
enable_device_indexer=false
# 0, indexer base on file; 1, indexer base on rocksdb
device_indexer_type=0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data_file_indexer_manager=internal/rocksdb

@mychaow
Copy link
Member Author

mychaow commented Sep 16, 2020

Hi, please change this interface to FileIndexManager and make the default implementation as DeviceTimeIndexEntry

ok

@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 40 Code Smells

No Coverage information No Coverage information
3.3% 3.3% Duplication

Copy link
Contributor

@SilverNarcissus SilverNarcissus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code. But need functionality and performance test

@@ -229,6 +229,13 @@ write_read_schema_free_memory_proportion=4:3:1:2
# primitive array size (length of each array) in array pool
primitive_array_size=128


# time indexer
enable_file_time_indexer=false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this parameter is false. We should open it and test it's functionality and performance

@mychaow mychaow closed this Nov 25, 2020
@mychaow
Copy link
Member Author

mychaow commented Nov 25, 2020

move to another pr #2115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants