New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOTDB-698] add device time index interface #1652
Conversation
Hi, could you add some description for this pr? |
yes, you could see some description in jira iotdb-698 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful work! We can keep away from OOM caused by metadata. Looking forward to your implementation. Only minor issues now, please have a look.
server/src/main/java/org/apache/iotdb/db/timeIndex/IndexerManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/timeIndex/IndexerManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/timeIndex/IndexerManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/timeIndex/IndexerManager.java
Outdated
Show resolved
Hide resolved
c9a65a4
to
f7458f1
Compare
14f3141
to
14b4449
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, please change this interface to FileIndexManager and make the default implementation as DeviceTimeIndexEntry
# device time indexer | ||
enable_device_indexer=false | ||
# 0, indexer base on file; 1, indexer base on rocksdb | ||
device_indexer_type=0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data_file_indexer_manager=internal/rocksdb
server/src/main/java/org/apache/iotdb/db/timeIndex/IndexerManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/timeIndex/TimeIndex.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/timeIndex/TimeIndexer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/timeIndex/TimeIndexer.java
Outdated
Show resolved
Hide resolved
ok |
6992bb0
to
113db46
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice code. But need functionality and performance test
@@ -229,6 +229,13 @@ write_read_schema_free_memory_proportion=4:3:1:2 | |||
# primitive array size (length of each array) in array pool | |||
primitive_array_size=128 | |||
|
|||
|
|||
# time indexer | |||
enable_file_time_indexer=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently this parameter is false. We should open it and test it's functionality and performance
move to another pr #2115 |
No description provided.