Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch NullPointerException and log error #2129

Merged
merged 1 commit into from
Nov 27, 2020
Merged

catch NullPointerException and log error #2129

merged 1 commit into from
Nov 27, 2020

Conversation

qiaojialin
Copy link
Member

For NullPointerException, it most likely a bug, so log it in error level.

For other statement execution error, warn is enough.

@sonarcloud
Copy link

sonarcloud bot commented Nov 26, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
31.5% 31.5% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 11.
Read more here

@qiaojialin qiaojialin merged commit abc6999 into master Nov 27, 2020
@qiaojialin qiaojialin deleted the fix_error_log_to_warn branch November 27, 2020 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HTHou HTHou HTHou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qiaojialin @HTHou