Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency bug and add documents #2299

Merged
merged 5 commits into from
Dec 21, 2020
Merged

Fix dependency bug and add documents #2299

merged 5 commits into from
Dec 21, 2020

Conversation

kr11
Copy link
Contributor

@kr11 kr11 commented Dec 21, 2020

  • Fix bug: change zeppelin-interpreter/pom.xml, package the interpreter with dependencies.
  • Add documents: EH and CN
  • Remove the duplicate README in zeppelin-interpreter/

To be discussed:
As the Github image website githubusercontent.com is unstable, Shall we create an image directory for all used images and refer to them with relative links? just like what zeppelin docs does.

For example, the images in UserGuide/Ecosystem Integration/Grafana.md may not display normally now.

@HTHou
Copy link
Contributor

HTHou commented Dec 21, 2020 •
edited
Loading

As the Github image website githubusercontent.com is unstable, Shall we create an image directory for all used images and refer to them with relative links? just like what zeppelin docs does.

I think it may cause another problem. When we clone the code from the IoTDB repository, we may have to download these images to our local computers. These images may take a lot of disk space....

@kr11
Copy link
Contributor Author

kr11 commented Dec 21, 2020 •
edited
Loading

As the Github image website githubusercontent.com is unstable, Shall we create an image directory for all used images and refer to them with relative links? just like what zeppelin docs does.

I think it may cause another problem. When we clone the code from the IoTDB repository, we may have to download these images to our local computers. These images may take a lot of disk space....

I understand and quite agree that we should separate image resources from the code repository.
The change has been done.

Just a few extra ideas. github.com and githubusercontent.com have different web links and ips, thus users may be able to view the former but blocked by the latter due to GFW. In the future, we could consider storing our images in another github.com repository, instead of githubusercontent.com , although it's really convenient.

@kr11 kr11 self-assigned this Dec 21, 2020
@kr11 @HTHou
Apply suggestions from code review
f97dd81 
Co-authored-by: Haonan <hhaonan@outlook.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

samperson1997
samperson1997 approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@samperson1997 samperson1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, great! I tried again in my local and test maven package. Everything works this time (zeppelin-iotdb-0.12.0-SNAPSHOT-jar-with-dependencies.jar is 8.3M).

@samperson1997 samperson1997 merged commit 2bdae11 into master Dec 21, 2020
@samperson1997 samperson1997 deleted the bug_zeppelin_dependency branch December 21, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samperson1997 samperson1997 samperson1997 approved these changes

@HTHou HTHou HTHou approved these changes

Assignees

@kr11 kr11

Labels
Module - Documents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kr11 @HTHou @samperson1997