[IOTDB-1079] Virtual storage group first mile stone #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_partition # Conflicts: # server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
…_partition # Conflicts: # server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
…_partition_2_merge # Conflicts: # server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java # server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
…_partition_2_merge
…_partition_2_merge
…_partition_2_merge
…_partition_2_merge
…_partition_2_merge
…_partition_2_merge
…_partition_2_merge
…_partition_2_merge # Conflicts: # server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
jt2594838
requested changes
Jan 14, 2021
server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/apache/iotdb/db/integration/IoTDBLoadExternalTsfileIT.java
Show resolved
Hide resolved
server/src/test/java/org/apache/iotdb/db/integration/IoTDBRemovePartitionIT.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/apache/iotdb/db/integration/IoTDBRestartIT.java
Show resolved
Hide resolved
server/src/test/java/org/apache/iotdb/db/sync/receiver/load/FileLoaderTest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/virtualSg/VirtualPartitioner.java
Outdated
Show resolved
Hide resolved
jt2594838
approved these changes
Jan 15, 2021
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
Outdated
Show resolved
Hide resolved
…_partition_2_merge # Conflicts: # server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
rhmangmang
reviewed
Jan 15, 2021
server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
Outdated
Show resolved
Hide resolved
jt2594838
approved these changes
Jan 15, 2021
Comment on lines
368
to
379
| logger.info("{} submit a compaction merge task", virtualstorageGroupName); | ||
| logger.info("{} submit a compaction merge task", virtualstorageGroupId); | ||
| try { | ||
| CompactionMergeTaskPoolManager.getInstance() | ||
| .submitTask( | ||
| tsFileManagement.new CompactionRecoverTask(this::closeCompactionMergeCallBack)); | ||
| } catch (RejectedExecutionException e) { | ||
| this.closeCompactionMergeCallBack(); | ||
| logger.error("{} compaction submit task failed", virtualstorageGroupName); | ||
| logger.error("{} compaction submit task failed", virtualstorageGroupId); | ||
| } | ||
| } else { | ||
| logger.error("{} compaction pool not started ,recover failed", | ||
| virtualstorageGroupName); | ||
| virtualstorageGroupId); |
There was a problem hiding this comment.
Storage group name is still missing in these logs. And please also check other places.
There was a problem hiding this comment.
Sure, I have fixed all the logs~
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently out concurrency unit is storage group which can't make full use of cpu cores when user only set 1 or 2 storage group. We need virtual storage group to improve concurrent performance. This PR finish first part of the design.
JIRA:
https://issues.apache.org/jira/projects/IOTDB/issues/IOTDB-1079?filter=myopenissues
Design: https://cwiki.apache.org/confluence/display/IOTDB/Separate+memory+and+disk+management+in+storage+group+road+map+design
Performance report:
https://tower.im/teams/138444/todos/16237/
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR