Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TsFile Docs #247

Merged
merged 22 commits into from
Jul 18, 2019
Merged

TsFile Docs #247

merged 22 commits into from
Jul 18, 2019

Conversation

mikip65
Copy link
Contributor

@mikip65 mikip65 commented Jul 16, 2019

Installation, Read and Write API usage provided examples.


```

##### Writing TsFile directly without defining the schema by json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
##### Writing TsFile directly without defining the schema by json
##### Writing TsFile with defining the schema by API

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we put this before Json? This is the most commonly used way.

tsRecord.addTuple(dPoint2);

// write a TSRecord to TsFile
tsFileWriter.write(tsRecord);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a DataPoint of sensor_3. Then, the following code could be omitted. They are duplicated...

* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license is not needed here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw there were license statements in other .md files.

@samperson1997
Copy link
Contributor

samperson1997 commented Jul 17, 2019

Documents in User Guide and file 0-content.md are also changed in PR#256. Maybe the order of new chapters (Chapter 7 and Chapter 8) needs to be discussed first to avoid conflict.

@fanhualta
Copy link
Contributor

I think it's better to rename Chapter 7 to Chapter 8, while Chapter 7 is for tools.

docs/Documentation/UserGuideV0.7.0/7-TsFile/2-Usage.md Outdated Show resolved Hide resolved
docs/Documentation/UserGuideV0.7.0/7-TsFile/2-Usage.md Outdated Show resolved Hide resolved
docs/Documentation/UserGuideV0.7.0/7-TsFile/2-Usage.md Outdated Show resolved Hide resolved
docs/Documentation/UserGuideV0.7.0/7-TsFile/2-Usage.md Outdated Show resolved Hide resolved
docs/Documentation/UserGuideV0.7.0/7-TsFile/2-Usage.md Outdated Show resolved Hide resolved
docs/Documentation/UserGuideV0.7.0/7-TsFile/2-Usage.md Outdated Show resolved Hide resolved
docs/Documentation/UserGuideV0.7.0/7-TsFile/2-Usage.md Outdated Show resolved Hide resolved
docs/Documentation/UserGuideV0.7.0/7-TsFile/2-Usage.md Outdated Show resolved Hide resolved
@qiaojialin qiaojialin merged commit a1b906d into apache:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants