-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TsFile Docs #247
TsFile Docs #247
Conversation
|
||
``` | ||
|
||
##### Writing TsFile directly without defining the schema by json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
##### Writing TsFile directly without defining the schema by json | |
##### Writing TsFile with defining the schema by API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we put this before Json? This is the most commonly used way.
tsRecord.addTuple(dPoint2); | ||
|
||
// write a TSRecord to TsFile | ||
tsFileWriter.write(tsRecord); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a DataPoint of sensor_3. Then, the following code could be omitted. They are duplicated...
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license is not needed here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw there were license statements in other .md files.
Documents in User Guide and file |
I think it's better to rename Chapter 7 to Chapter 8, while Chapter 7 is for tools. |
Installation, Read and Write API usage provided examples.