Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOTDB-1319] Trigger module: alert manager sink #3057

Merged
merged 15 commits into from Apr 28, 2021

Conversation

mzp0514
Copy link
Contributor

@mzp0514 mzp0514 commented Apr 24, 2021

Description

Content1 ...

Content2 ...

Content3 ...


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@mzp0514 mzp0514 force-pushed the sink branch 2 times, most recently from ac188e6 to 3d0d451 Compare April 24, 2021 12:23
@SteveYurongSu
Copy link
Member

Please rename this PR to:

[IOTDB-1319] Trigger module: alert manager sink

@mzp0514 mzp0514 changed the title Sink Trigger module: alert manager sink Apr 26, 2021
@mzp0514 mzp0514 changed the title Trigger module: alert manager sink [IOTDB-1319] Trigger module: alert manager sink Apr 26, 2021
@mzp0514 mzp0514 force-pushed the sink branch 6 times, most recently from 2b2d85e to db2141a Compare April 27, 2021 03:55
annotations.put("summary", "high temperature");
annotations.put("description", "{{.alertname}}: {{.series}} is {{.value}}");
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we override onStart() / onStop()?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the client be reopened?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Member

@SteveYurongSu SteveYurongSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution.

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit a6401e4 into apache:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants