Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOTDB-1348] Last plan not work in cluster mode #3118

Merged
merged 4 commits into from
May 7, 2021
Merged

[IOTDB-1348] Last plan not work in cluster mode #3118

merged 4 commits into from
May 7, 2021

Conversation

irvine0109
Copy link
Member

@irvine0109 irvine0109 commented Apr 30, 2021

Uploading image.png…

Last plan not work in cluster mode, and I think timeValuePairs.get(i).right also should be judged as not null.

jira link

@irvine0109 irvine0109 changed the title [IOTDB-1153] Last plan not work in cluster mode [IOTDB-1348] Last plan not work in cluster mode Apr 30, 2021
@jixuan1989
Copy link
Member

Hi, strongly suggest to add test in testcontainer module.

@HTHou HTHou added the Module - Cluster PRs for the cluster module label May 4, 2021
@irvine0109
Copy link
Member Author

Hi, strongly suggest to add test in testcontainer module.

Done.

Copy link
Member

@mychaow mychaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and please cherry-pick to 0.12 branch.

Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
please execute mvn spotless:apply to resolve format issues~

@JackieTien97 JackieTien97 merged commit 8907772 into apache:master May 7, 2021
HeimingZ pushed a commit to HeimingZ/iotdb that referenced this pull request May 7, 2021
* [IOTDB-1153] Last plan not work in cluster mode
@mychaow
Copy link
Member

mychaow commented May 18, 2021

Hi,could you please cherry-pick the pr to rel/0.12.

mychaow pushed a commit that referenced this pull request May 18, 2021
@irvine0109 irvine0109 deleted the PR1348 branch August 15, 2021 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module - Cluster PRs for the cluster module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants