New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOTDB-2144][Metric] Collect IoTDB Runtime Metrics #4573
[IOTDB-2144][Metric] Collect IoTDB Runtime Metrics #4573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job! From my perspective, there are some problems need to fix.
metrics/interface/src/main/assembly/resources/conf/iotdb-metric.yml
Outdated
Show resolved
Hide resolved
metrics/interface/src/main/java/org/apache/iotdb/metrics/config/MetricConfig.java
Outdated
Show resolved
Hide resolved
@LebronAl This PR contains some metrics in cluster module, PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for cluster related metric
Thanks for the work of @xinzhongtianxia, now we have a performance report. The report shows that the current monitoring points have no impact on performance. Disable metrics:
Enable metrics:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty nice!
Description
Benefit from the metric framework, we could now collect some core IoTDB Runtime metrics, which will help users get a clear sight of their IoTDB's status and will also help RD an SRE resolve problems or establish their own monitor systems.
jira:
https://issues.apache.org/jira/browse/IOTDB-2144