[IOTDB-2524] Aligned Timeseries support tags and attributes #5191

RYH61 · 2022-03-09T14:22:31Z

IoTDB> create aligned timeseries root.sg1.d1(s1 INT32 tags(tag1=v1, tag2=v2) attributes(attr1=v1, attr2=v2), s2 DOUBLE tags(tag3=v3, tag4=v4) attributes(attr3=v3, attr4=v4))

IoTDB> show timeseries
+--------------+-----+-------------+--------+--------+-----------+-------------------------+---------------------------+
| timeseries|alias|storage group|dataType|encoding|compression| tags| attributes|
+--------------+-----+-------------+--------+--------+-----------+-------------------------+---------------------------+
|root.sg1.d1.s1| null| root.sg1| INT32| RLE| SNAPPY|{"tag1":"v1","tag2":"v2"}|{"attr2":"v2","attr1":"v1"}|
|root.sg1.d1.s2| null| root.sg1| DOUBLE| GORILLA| SNAPPY|{"tag4":"v4","tag3":"v3"}|{"attr4":"v4","attr3":"v3"}|
+--------------+-----+-------------+--------+--------+-----------+-------------------------+---------------------------+

coveralls · 2022-03-09T15:27:03Z

Coverage decreased (-2.3%) to 65.575% when pulling c34cb8c on RYH61:renyuhua into 064010c on apache:master.

HTHou · 2022-03-14T05:44:47Z

@MarcosZyk Can you please take a look if you have time?

MarcosZyk

Excellent work! Only one problem exists. Please have a look.

server/src/main/java/org/apache/iotdb/db/service/thrift/impl/TSServiceImpl.java

MarcosZyk

LGTM~

HTHou · 2022-03-14T12:43:19Z

Hi, consider updating the API? Java, python, c++…
Also, don’t forget update the user guide for new feature.

HTHou · 2022-03-16T01:48:06Z

docs/zh/UserGuide/Operate-Metadata/Timeseries.md

+
+创建对齐时间序列
+
+```
+create aligned timeseries root.sg1.d1(s1 INT32 tags(tag1=v1, tag2=v2) attributes(attr1=v1, attr2=v2), s2 DOUBLE tags(tag3=v3, tag4=v4) attributes(attr3=v3, attr4=v4))


Hi, you can modify this part of the doc.

iotdb/docs/zh/UserGuide/Operate-Metadata/Timeseries.md

Lines 56 to 66 in 2f78450

## 创建对齐时间序列

创建一组对齐时间序列的SQL语句如下所示：

```

IoTDB> CREATE ALIGNED TIMESERIES root.ln.wf01.GPS(latitude FLOAT encoding=PLAIN compressor=SNAPPY, longitude FLOAT encoding=PLAIN compressor=SNAPPY)

```

一组对齐序列中的序列可以有不同的数据类型、编码方式以及压缩方式。

对齐的时间序列暂不支持设置别名、标签、属性。

HTHou · 2022-03-16T01:51:11Z

session/src/main/java/org/apache/iotdb/session/Session.java

      List<TSDataType> dataTypes,
      List<TSEncoding> encodings,
      List<CompressionType> compressors,
-      List<String> measurementAliasList)
+      List<String> measurementAliasList,
+      List<Map<String, String>> tagsList,
+      List<Map<String, String>> attributesList)


IMO, adding a new interface rather than changing the old one is better for compatibility...

And don't forget update the doc of API.

iotdb/docs/UserGuide/API/Programming-Java-Native-API.md

Lines 150 to 157 in 2f78450

* Create aligned timeseries

```

void createAlignedTimeseries(String prefixPath, List<String> measurements,

List<TSDataType> dataTypes, List<TSEncoding> encodings,

CompressionType compressor, List<String> measurementAliasList);

```

Attention: Alias of measurements are **not supported** currently.

Aligned Timeseries support tags and attributes

427384d

Aligned Timeseries support tags and attributes

00fc081

mychaow requested a review from HTHou March 14, 2022 02:12

MarcosZyk reviewed Mar 14, 2022

View reviewed changes

server/src/main/java/org/apache/iotdb/db/service/thrift/impl/TSServiceImpl.java Show resolved Hide resolved

MarcosZyk approved these changes Mar 14, 2022

View reviewed changes

Add user guide and modify JavaAPI

c34cb8c

HTHou reviewed Mar 16, 2022

View reviewed changes

qiaojialin approved these changes Mar 16, 2022

View reviewed changes

qiaojialin merged commit 1ff6db9 into apache:master Mar 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IOTDB-2524] Aligned Timeseries support tags and attributes #5191

[IOTDB-2524] Aligned Timeseries support tags and attributes #5191

RYH61 commented Mar 9, 2022 •

edited by HTHou

coveralls commented Mar 9, 2022 •

edited

HTHou commented Mar 14, 2022

MarcosZyk left a comment

MarcosZyk left a comment

HTHou commented Mar 14, 2022 •

edited

HTHou Mar 16, 2022

RYH61 Mar 16, 2022

HTHou Mar 16, 2022

HTHou Mar 16, 2022 •

edited

RYH61 Mar 16, 2022

	## 创建对齐时间序列

	创建一组对齐时间序列的SQL语句如下所示：

	```
	IoTDB> CREATE ALIGNED TIMESERIES root.ln.wf01.GPS(latitude FLOAT encoding=PLAIN compressor=SNAPPY, longitude FLOAT encoding=PLAIN compressor=SNAPPY)
	```

	一组对齐序列中的序列可以有不同的数据类型、编码方式以及压缩方式。

	对齐的时间序列暂不支持设置别名、标签、属性。

	* Create aligned timeseries
	```
	void createAlignedTimeseries(String prefixPath, List<String> measurements,
	List<TSDataType> dataTypes, List<TSEncoding> encodings,
	CompressionType compressor, List<String> measurementAliasList);
	```

	Attention: Alias of measurements are not supported currently.

[IOTDB-2524] Aligned Timeseries support tags and attributes #5191

[IOTDB-2524] Aligned Timeseries support tags and attributes #5191

Conversation

RYH61 commented Mar 9, 2022 • edited by HTHou

coveralls commented Mar 9, 2022 • edited

HTHou commented Mar 14, 2022

MarcosZyk left a comment

Choose a reason for hiding this comment

MarcosZyk left a comment

Choose a reason for hiding this comment

HTHou commented Mar 14, 2022 • edited

HTHou Mar 16, 2022

Choose a reason for hiding this comment

RYH61 Mar 16, 2022

Choose a reason for hiding this comment

HTHou Mar 16, 2022

Choose a reason for hiding this comment

HTHou Mar 16, 2022 • edited

Choose a reason for hiding this comment

RYH61 Mar 16, 2022

Choose a reason for hiding this comment

RYH61 commented Mar 9, 2022 •

edited by HTHou

coveralls commented Mar 9, 2022 •

edited

HTHou commented Mar 14, 2022 •

edited

HTHou Mar 16, 2022 •

edited