[IOTDB-2930]Fix concurrent UnPin bug & Improve template implementation #5647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosZyk
changed the title
qiaojialin
approved these changes
Apr 23, 2022
xinzhongtianxia
added a commit
to xinzhongtianxia/iotdb
that referenced
this pull request
Apr 24, 2022
* remotes/upstream/master: [IOTDB-2996] Fix wildcard import in test folders (apache#5652) [IOTDB-2955] Design and implement ClientManager for thrift client's pooling management (apache#5595) [IOTDB-2945] Reconstruct ConfigNode manage layer and persistence layer (apache#5627) Fix import wildcard violation [IOTDB-2933] detect sender exit and set pipestatus=STOP (apache#5557) [IOTDB-2989] Expression Serialize & Deserialize (apache#5649) [IOTDB-2930]Fix concurrent UnPin bug & Improve template implementation (apache#5647) [IOTDB-2984] RatisConsensus Recovery Logic (apache#5648) [IOTDB-2979] Optimize the serialization and deserialization of thrift data structures (apache#5637) Add config example for new cluster (apache#5624) [IOTDB-2982] Recover tsfile after datanode restart (apache#5643) Fix TimeJoinNode clone and serde bug (apache#5644) Refactor attributes in PlanNode (apache#5616) # Conflicts: # server/src/main/java/org/apache/iotdb/db/mpp/sql/parser/ASTVisitor.java # server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/plan/node/metedata/read/SchemaFetchNode.java # server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/plan/node/metedata/read/SchemaMergeNode.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix concurrent UnPin bug
After a thread unPin a node, it should check the cache status of the node. If the node is now not Pinned, then its parent should be unPin once, which means one of the children is not pinned any more. However, the operation and check should be synchronized, otherwise the change may result in multi threads get wrong cache status and do extra unpin, which may result in negative semaphore value.
Improve template implementation
The old implementation of template check during insert takes low performance and is hard to understand. Thus the implementation is rewritten.