[IOTDB-3012][De-Singleton-1] remove singleton pattern for some classes #5672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengjianyun
force-pushed
the
jianyun/de-singleton
branch
from
6622cbb
to
b1e02d6
Compare
wangchao316
changed the title
chengjianyun
changed the title
JackieTien97
approved these changes
Apr 26, 2022
|
SonarCloud Quality Gate failed. |
xinzhongtianxia
added a commit
to xinzhongtianxia/iotdb
that referenced
this pull request
Apr 27, 2022
* remotes/upstream/master: Update dbeaver user guide (apache#5675) [IOTDB-3012][De-Singleton-1] remove singleton pattern for some classes (apache#5672) [IOTDB-3000] ConfigNode supports MTreeAboveSG (apache#5670) [IOTDB-2803]fix some UT code smell and refine plannode serialize (apache#5667) [IOTDB-3003] data sync pipe recover bug & other issues (apache#5665) Use logical clock to fix clientManager test (apache#5671) extract interface from path (apache#5662) Implement MultiColumnMerger to support querying data of one timeseries distributed on different DataNodes (apache#5663) [IOTDB-2845] Implementation of DeviceViewOperator Part1 (apache#5613)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As have discussed, singleton pattern is making code inflexible, hard to make UI and IT tests. We shouldn't use singleton pattern too much.
I'd like to propose several PRs to remove the singleton pattern for most of singleton pattern implementations before the
getInstance()are widely used. This one is the first.