[IOTDB-3184] Feature/delete timeseries #5911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosZyk
reviewed
May 16, 2022
Comment on lines
+93
to
+113
| public List<WritePlanNode> splitByPartition(Analysis analysis) { | ||
| for (PartialPath deletedPath : deletedPaths) { | ||
| String device = deletedPath.getDevice(); | ||
| TRegionReplicaSet schemaRegionReplicaSet = | ||
| analysis.getSchemaPartitionInfo().getSchemaRegionReplicaSet(device); | ||
| DeleteTimeSeriesSchemaNode deleteTimeSeriesSchemaNode = | ||
| new DeleteTimeSeriesSchemaNode(this.getPlanNodeId(), deletedPath); | ||
| deleteTimeSeriesSchemaNode.setRegionReplicaSet(schemaRegionReplicaSet); | ||
| schemaRegionSpiltMap.putIfAbsent(deletedPath, deleteTimeSeriesSchemaNode); | ||
| List<TRegionReplicaSet> dataRegionReplicaSets = | ||
| analysis.getDataPartitionInfo().getDataRegionReplicaSet(device, null); | ||
| DeleteTimeSeriesDataNode deleteTimeSeriesDataNode = | ||
| new DeleteTimeSeriesDataNode(this.getPlanNodeId(), deletedPath); | ||
| for (TRegionReplicaSet dataRegionReplicaSet : dataRegionReplicaSets) { | ||
| deleteTimeSeriesDataNode.setRegionReplicaSet(dataRegionReplicaSet); | ||
| dataRegionSplitMap | ||
| .computeIfAbsent(deletedPath, k -> new ArrayList<>()) | ||
| .add(deleteTimeSeriesDataNode); | ||
| } | ||
| } | ||
| return Collections.singletonList(this); |
There was a problem hiding this comment.
I think it's better to implement this as a logical PlanNode tree construction in logicalPlanner, rather than invade into the FragmentInstanceDispatcher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare statement
set storage group to root.sg;
create timeseries root.sg.d.s1 with datatype=INT32,encoding=RLE,compression=snappy;
create timeseries root.sg.d.s2 with datatype=INT32,encoding=RLE,compression=snappy;
create timeseries root.sg.d.s3 with datatype=INT32,encoding=RLE,compression=snappy;
insert into root.sg.d(time,s1,s2,s3) values(1,1,2,3);
insert into root.sg.d(time,s1,s2,s3) values(2,1,2,3);
set storage group to root.sg1;
create timeseries root.sg1.d.s1 with datatype=INT32,encoding=RLE,compression=snappy;
create timeseries root.sg1.d.s2 with datatype=INT32,encoding=RLE,compression=snappy;
create timeseries root.sg1.d.s3 with datatype=INT32,encoding=RLE,compression=snappy;
insert into root.sg1.d(time,s1,s2,s3) values(1,1,2,3);
insert into root.sg1.d(time,s1,s2,s3) values(2,1,2,3);
set storage group to root.sg2;
create timeseries root.sg2.d.s1 with datatype=INT32,encoding=RLE,compression=snappy;
create timeseries root.sg2.d.s2 with datatype=INT32,encoding=RLE,compression=snappy;
create timeseries root.sg2.d.s3 with datatype=INT32,encoding=RLE,compression=snappy;
insert into root.sg2.d(time,s1,s2,s3) values(1,1,2,3);
insert into root.sg2.d(time,s1,s2,s3) values(2,1,2,3);
test1: delete single timeseries
test2: delete with "*"