Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOTDB-3184] Implement Timeseries version and blacklist #5998

Merged
merged 12 commits into from May 24, 2022
Merged

[IOTDB-3184] Implement Timeseries version and blacklist #5998

merged 12 commits into from May 24, 2022

Conversation

MarcosZyk
Copy link
Contributor

@MarcosZyk MarcosZyk commented May 24, 2022 •
edited

Description

Implement Timeseries version

  1. When generating createTimeseriesNode, a version will be generated for timeseries possibly created by this request
  2. Store version in measurementMNode and DataNodeSchemaCache, and transport it via MeasurementPath and SchemaTree
  3. There's no need to persist version in mlog, since the black list will only be constructed during system running and it's just a runtime check

Add blacklist to SchemaValidator

The blacklist is mainly used to filtering insertion. Thus it is set in SchemaValidator. All the fetched schema should go through the blacklist check.

Remove alias from DataNodeSchemaCache

The alias feature is developed to help data query rather than insertion. Remove it from DataNodeSchemaCache to simplify the process of alias updating operation.

Future work

  1. Implement blacklist operation
  2. Implement DeteleTimeseries based on version and blacklist

yifuzhou
yifuzhou approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@yifuzhou yifuzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ just kindly reminder that storageGroup should also has the version in confignode cache.

@xingtanzjr xingtanzjr merged commit 4e3e720 into apache:master May 24, 2022
liuminghui233 pushed a commit to liuminghui233/iotdb that referenced this pull request May 25, 2022
@MarcosZyk @liuminghui233
[IOTDB-3184] Implement Timeseries version and blacklist (apache#5998)
a024ef7
liuminghui233 added a commit to liuminghui233/iotdb that referenced this pull request May 25, 2022
@liuminghui233
Revert "[IOTDB-3184] Implement Timeseries version and blacklist (apac…
8a60557 
…he#5998)"

This reverts commit a024ef7.
@MarcosZyk MarcosZyk deleted the timeseries_uuid branch May 27, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yifuzhou yifuzhou yifuzhou approved these changes

@xingtanzjr xingtanzjr xingtanzjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarcosZyk @yifuzhou @xingtanzjr