Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOTDB-4855] [MultiLeader] Strength the memory control #8025

Merged
merged 9 commits into from
Nov 23, 2022
Merged

[IOTDB-4855] [MultiLeader] Strength the memory control #8025

merged 9 commits into from
Nov 23, 2022

Conversation

OneSizeFitsQuorum
Copy link
Contributor

This PR also solved issue 4873

OneSizeFitsQuorum and others added 8 commits November 18, 2022 16:13
@OneSizeFitsQuorum
Control the size of each pending batch to be no larger than maxSizePe…
aec63e2 
…rBatch

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
@SpriCoder @OneSizeFitsQuorum
Add memory control of SyncStatus and strength memory control of Queue (…
6c53329 
…#7956)
@OneSizeFitsQuorum
fix wrong memory allocation calculation
f57914f 
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
@OneSizeFitsQuorum
fix UT
5064082 
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
@OneSizeFitsQuorum
refine dispatcher logic
5640991 
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
@OneSizeFitsQuorum
enhance TLogBatch struct
947b0f3 
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
@OneSizeFitsQuorum
adjust maxSizePerBatch from 4M to 16M
3441037 
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
@OneSizeFitsQuorum
fix gap from wal bug
a767285 
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
@OneSizeFitsQuorum OneSizeFitsQuorum force-pushed the multi_leader_memory_pendingBatch_control branch from 57da519 to a767285 Compare November 18, 2022 08:16
@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@HeimingZ
Copy link
Contributor

I test three scenarios and all of them have consistent data:

  • data are consistent when writing normally
    lab1
  • data are consistent when datanode was killed
    lab2
  • data are consistent when datanode was read-only
    lab3

@xingtanzjr xingtanzjr merged commit de2617c into master Nov 23, 2022
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the multi_leader_memory_pendingBatch_control branch November 24, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xingtanzjr xingtanzjr xingtanzjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OneSizeFitsQuorum @HeimingZ @xingtanzjr @SpriCoder