[To rel/1.0] [IOTDB-4940] Optimize query fetch data partition process while containg unclosed time filter #8230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRZbulabula
reviewed
Nov 28, 2022
Comment on lines
31
to
37
| // it will be set to true in query when there exist filter like: time <= XXX | ||
| // (-oo, timePartitionSlotList.get(0)] | ||
| private boolean needLeftAll = false; | ||
|
|
||
| // it will be set to true query when there exist filter like: time >= XXX | ||
| // [timePartitionSlotList.get(timePartitionSlotList.size() - 1), +oo) | ||
| private boolean needRightAll = false; |
There was a problem hiding this comment.
The annotation shows that these two parameters indicate two close intervals. However in the implementation of SeriesPartitionTable, these two parameters indicate two open intervals.
There was a problem hiding this comment.
The margin partition will be added （if need）in previous process code.
|
SonarCloud Quality Gate failed. |
Beyyes
approved these changes
Nov 28, 2022
qiaojialin
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize sqls like
where time < 10
where time > 20
where time < 10 or time>20