[To rel/1.0][IOTDB-5093]Fix compaction selector bug #8267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choubenson
changed the title
THUMarkLau
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
target file overlap with previous file
Reason
In the process of getting the file list and starting to select files, the file list is updated (the file is deleted or the status is updated). When a seq file is occupied and deleted by other compaction thread, and it happens to select files in cross space compaction, the deleted file will be filtered out, resulting in an overlap target file.
Solution
Do not filter out any seq files before selecting the files. After selecting the files, judge whether the seq files have been deleted or being compacted. If there are any, the task will be discarded.