[To rel/1.0] Cherry pick cluster node start protocol for rel/1.0 #8592
Conversation
Beyyes
changed the title
| // Notice: The Seed-ConfigNode must also have the privilege to give system configuration. | ||
| // Otherwise, the IoTDB-cluster will not have the ability to restart from scratch. | ||
| if (status.getCode() == TSStatusCode.SUCCESS_STATUS.getStatusCode() | ||
| || ConfigNodeDescriptor.getInstance().isSeedConfigNode() |
There was a problem hiding this comment.
Remove || ConfigNodeDescriptor.getInstance().isSeedConfigNode() || SystemPropertiesUtils.isSeedConfigNode() judgement?
There was a problem hiding this comment.
No. The Seed-ConfigNode must also have the privilege to give system configuration.
| TSStatus status = confirmLeader(); | ||
| // Notice: The Seed-ConfigNode must also have the privilege to do Node restart check. | ||
| // Otherwise, the IoTDB-cluster will not have the ability to restart from scratch. | ||
| if (status.getCode() == TSStatusCode.SUCCESS_STATUS.getStatusCode() |
There was a problem hiding this comment.
Remove || ConfigNodeDescriptor.getInstance().isSeedConfigNode() || SystemPropertiesUtils.isSeedConfigNode() judgement?
There was a problem hiding this comment.
No. The Seed-ConfigNode must also have the privilege to do Node restart check.
| // Notice: The Seed-ConfigNode must also have the privilege to do Node restart check. | ||
| // Otherwise, the IoTDB-cluster will not have the ability to restart from scratch. | ||
| if (status.getCode() == TSStatusCode.SUCCESS_STATUS.getStatusCode() | ||
| || ConfigNodeDescriptor.getInstance().isSeedConfigNode() |
There was a problem hiding this comment.
Remove || ConfigNodeDescriptor.getInstance().isSeedConfigNode()?
There was a problem hiding this comment.
No. The Seed-ConfigNode must also have the privilege to do Node restart check.
| if (clusterName == null) { | ||
| LOGGER.warn( | ||
| "Lack cluster_name field in data/confignode/system/confignode-system.properties, set it as defaultCluster"); | ||
| systemProperties.setProperty("cluster_name", "defaultCluster"); |
There was a problem hiding this comment.
Change to constant CLUSTER_NAME and DEFAULT_CLUSTER_NAME
| private static final int SCHEDULE_WAITING_RETRY_NUM = 20; | ||
| private static final long STARTUP_RETRY_INTERVAL_IN_MS = TimeUnit.SECONDS.toMillis(30); |
There was a problem hiding this comment.
30000ms? before is 1000ms
| // Check system configurations | ||
| IoTDBStartCheck.getInstance().checkSystemConfig(); | ||
|
|
||
| return isFirstStart; |
There was a problem hiding this comment.
return !SYSTEM_PROPERTIES.exists();
There was a problem hiding this comment.
No. The system.properties file will be created in IoTDBStartCheck.getInstance().checkSystemConfig(). So we should get the isFirstStart at the beginning
|
SonarCloud Quality Gate failed. |
I have tested the compatibility from 1.0 to 1.0.1
1.0 lib:
1.0.1 lib:
