Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add groupByExecutor main method doc #877

Merged
merged 6 commits into from Mar 3, 2020
Merged

add groupByExecutor main method doc #877

merged 6 commits into from Mar 3, 2020

Conversation

liutaohua
Copy link
Contributor

No description provided.

取出来的数据再调用 `calcFromBatch` 方法完成遍历所有聚合函数对 `BatchData` 的计算。

`calcResult` 方法的主要逻辑:
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a blank line before ```

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

}
```

`readAndCalcFromPage` 方法是从当前打开的chunk中获取page的数据,并计算聚合结果,主要逻辑:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加一个返回值的介绍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, thanks for you advice

@qiaojialin qiaojialin merged commit b5a7227 into apache:series_reader_doc Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants