ISIS-1979: Refactor logging in headless runtime and prevent configuri… #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng log4j twice thout these changes, IsisSystem is setting up log4j which is too late since other classes which bootstrap Isis require logging to work. Currently, HeadlessWithBootstrappingAbstract configures log4j in addition to IsisSystem. IsisSystem sets up logging either through logging.properties or a fallback. But logging.properties does not always exist (integration tests). Without logging.properties the fallback adds a console appender to the root logger in addition to any configuration in logging-integtest.properties, resulting in duplicated logs in integration tests. This commit removes any logging setup from IsisSystem. HeadlessWithBootstrappingAbstract now uses the IsisLoggingConfigurer which is normally used to set up logging. This requires IsisLoggingConfigurer to be flexible as to the basename of the configuration file. Also, some code duplication is refactored into LeveledLogger.
andi-huber
reviewed
Sep 8, 2018
| @@ -0,0 +1,36 @@ | |||
| package org.apache.isis.core.runtime.headless.logging; | |||
There was a problem hiding this comment.
just to let you know: files do need a license header; but I can fix that after merge
andi-huber
reviewed
Sep 8, 2018
| configureLoggingWithFile(configDirectory + "/" + LoggingConstants.LOGGING_CONFIG_FILE, args); | ||
| } | ||
|
|
||
| public void configureLoggingWithFile(final String configFile, final String[] args) { |
|
You know, contributions, that reduce lines of code, are the best. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g log4j twice
Without these changes, IsisSystem is setting up log4j which is too late since other classes which
bootstrap Isis require logging to work. Currently, HeadlessWithBootstrappingAbstract configures log4j in
addition to IsisSystem. IsisSystem sets up logging either through logging.properties or a fallback. But
logging.properties does not always exist (integration tests). Without logging.properties the fallback
adds a console appender to the root logger in addition to any configuration in logging-integtest.properties,
resulting in duplicated logs in integration tests.
This commit removes any logging setup from IsisSystem. HeadlessWithBootstrappingAbstract now uses the
IsisLoggingConfigurer which is normally used to set up logging. This requires IsisLoggingConfigurer to
be flexible as to the basename of the configuration file.
Also, some code duplication is refactored into LeveledLogger.