Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JCRVLT-646 Potential javax.jcr.nodetype.ConstraintViolationException while deserializing extended file aggregates #240

Merged
merged 3 commits into from Jul 29, 2022

Conversation

kwin
Copy link
Member

@kwin kwin commented Jul 28, 2022

No description provided.

@kwin kwin requested a review from reschke July 28, 2022 14:48
Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should strip the contents further down so that no content with non-Apache copyrights is left...

@kwin kwin force-pushed the bugfix/nt-file-import-failure branch from 6caaaee to 51ec533 Compare July 28, 2022 18:05
@kwin kwin changed the title Bugfix/nt file import failure JCRVLT-646 Potential javax.jcr.nodetype.ConstraintViolationException while deserializing extended file aggregates Jul 28, 2022
@kwin kwin force-pushed the bugfix/nt-file-import-failure branch from 51ec533 to 588af1e Compare July 28, 2022 18:13
@kwin kwin marked this pull request as ready for review July 28, 2022 18:13
@kwin kwin requested a review from reschke July 28, 2022 18:14
@kwin
Copy link
Member Author

kwin commented Jul 28, 2022

I believe we should strip the contents further down

Done now. Please have another look.

when deserializing enhanced file aggregate

improve logging for failed intermediate saves
@kwin kwin force-pushed the bugfix/nt-file-import-failure branch from 588af1e to d033540 Compare July 28, 2022 19:08
Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will run IT in AEM tomorrow.

@kwin kwin merged commit f6950ad into master Jul 29, 2022
@kwin kwin deleted the bugfix/nt-file-import-failure branch July 29, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants